Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow Redis client to be injected #5034

Merged
merged 4 commits into from Apr 6, 2021
Merged

feat: Allow Redis client to be injected #5034

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c1a1b7
Allow Redis client to be injected
adamnoakes Mar 15, 2021
ed4d466
Merge branch 'main' into an/injectable_redis_client
adamnoakes Mar 23, 2021
06922f2
Make nodes call typesafer
glasser Mar 25, 2021
5b3812d
override mget for cluster
adamnoakes Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/apollo-server-cache-redis/src/RedisClusterCache.ts
View file
Open in desktop
Expand Up @@ -10,7 +10,15 @@ export class RedisClusterCache extends BaseRedisCache {

constructor(nodes: ClusterNode[], options?: ClusterOptions) {
const clusterClient = new Redis.Cluster(nodes, options)
super(clusterClient);
super({
del: clusterClient.del.bind(clusterClient),
flushdb: clusterClient.flushdb.bind(clusterClient),
mget(...keys: Array<string>): Promise<Array<string | null>> {
return Promise.all(keys.map(key => clusterClient.get(key).catch(() => null)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm raising a pretty big eyebrow at that "ignore all errors" catch, but I see that it's copied from the previous version, so not gonna worry about it.

},
quit: clusterClient.quit.bind(clusterClient),
set: clusterClient.set.bind(clusterClient),
});
this.clusterClient = clusterClient;
}

Expand Down