chore(op-reg): adjustments and cleanup to existing tests. #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all meant to be the same in all cases.
Previously, we were leveraging `sendReportsImmediately` to ... do exactly that even though these tests don't need to send reports _at all_!. This was purely a hack to make sure that we don't need to wait for the Engine Reporting Agent to eventually fail (after 5 seconds or whatever its reporting interval is). This new `reportTiming` option is available with the below-linked PR, so we can now clean this up a bit. This has the added advantage of not hitting our actual reporting endpoint with an invalid API key, and having the logs spew errors about failures in delivering those doomed reports. Ref: #3918
These just aren't used!
While we do memoize the values of `process.env` that we check, this message is a bit confusing because of this phrasing. We really only do this to make testing easier, not because of any substantial runtime savings.
abernix
changed the title
|
Removed the word |
abernix
changed the title
trevor-scheer
approved these changes
Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, via multiple commits:
reportTimingoption toEngineReportingOptions#3918 (which makes some of the warnings which were output during test invocations disappear).relevant.
Individual should have more details, and I'm suggesting a merge for this when it lands to preserve those commit messages.