Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema-reporting: Add startup logging to schema reporting #4240

Conversation

sachindshinde
Copy link
Contributor

This PR adds startup logging to schema reporting, specifically logging at INFO level the options and the EdgeServerInfo object.

@abernix abernix added this to the 2.14.4 milestone Jun 12, 2020
@abernix
Copy link
Member

abernix commented Jun 12, 2020

This isn't meant to circumvent @jsegaran's request for review, however, given that automatic schema reporting is still "experimental" (and prefixed experimental_ as such), we're going to put this into the patch release today before #4236 happens in the next major (which would probably pair well with #3918, I imagine?).

Certainly don't let that prevent important follow-up changes to this, based on @jsegaran's review though. 😉

@abernix abernix merged commit 4490478 into sachin/remove-experimental-from-schema-reporting Jun 12, 2020
@abernix abernix deleted the sachin/add-startup-logging-to-schema-reporting branch June 12, 2020 13:20
@abernix
Copy link
Member

abernix commented Jun 12, 2020

I certainly didn't notice that this was targeting another branch on #4236 that I was referring to. 😄

Therefore, I've cherry picked it into master as well: 34a5c54

@sachindshinde
Copy link
Contributor Author

Sounds good to me 🙂 (there was a slight dependency on #4236 for options names in the logs, but @trevor-scheer fixed that in 1033029 .

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants