Commits on May 28, 2020

1. server-testing: Ensure user-provided context objects are cloned. …

   The `apollo-server-testing` package uses an internal Apollo Server method
   called `executeOperation` (introduced in [#1909]) in order to power its
   `createTestClient` functionality.  This is the testing practice which is
   documented within [Integration testing] in the Apollo Server documentation.
   
   However, it failed to introduce the same context-cloning which [takes place
   in `runHttpQuery`][Ref 1], prior to arriving at the main request pipeline.
   
   Since the context was not cloned, and we had made the expectation in [#3988]
   that it was a unique context on every single request (which it was, in a
   non-testing context), the Symbol we use to implement `willResolveField` was
   already present [on the request pipeline][Ref 2] when running a subsequent
   test via `createTestClient`!
   
   This commit introduces the same cloning that takes place in
   `buildRequestContext` within `runHttpQuery`, and adds tests to ensure the
   behavior is preserved.
   
   [Fixes #4170]: #4170
   [#1909]: #1909
   [Integration testing]: https://www.apollographql.com/docs/apollo-server/testing/testing/
   [Ref 1]: https://git.io/Jfou6
   [#3988]: #3988
   [Ref 2]: https://git.io/Jfouy

   

   abernix committed May 28, 2020
   Copy the full SHA

   79c0025 View commit details

   Browse the repository at this point in the history

2. Merge commit 'refs/pull/4064/head' of github.com:apollographql/apollo… …

   …-server into release-2.14.1

   

   abernix committed May 28, 2020
   Copy the full SHA

   49c44eb View commit details

   Browse the repository at this point in the history

3. Merge branch 'abernix/fix-executeOperation-context-cloning' into rele… …

   …ase-2.14.1

   

   abernix committed May 28, 2020
   Copy the full SHA

   0790ec0 View commit details

   Browse the repository at this point in the history

4. Fix typo in comment

   

   abernix committed May 28, 2020
   Copy the full SHA

   e9aef8c View commit details

   Browse the repository at this point in the history

5. Update CHANGELOG.md prior to publishing.

   

   abernix committed May 28, 2020
   Copy the full SHA

   612f4b8 View commit details

   Browse the repository at this point in the history

6. Release …

    - @apollo/federation@0.16.2
    - @apollo/gateway@0.16.2
    - apollo-server-azure-functions@2.14.1
    - apollo-server-cloud-functions@2.14.1
    - apollo-server-cloudflare@2.14.1
    - apollo-server-core@2.14.1
    - apollo-server-express@2.14.1
    - apollo-server-fastify@2.14.1
    - apollo-server-hapi@2.14.1
    - apollo-server-integration-testsuite@2.14.1
    - apollo-server-koa@2.14.1
    - apollo-server-lambda@2.14.1
    - apollo-server-micro@2.14.1
    - apollo-server-testing@2.14.1
    - apollo-server@2.14.1

   

   abernix committed May 28, 2020
   Copy the full SHA

   2da65ef View commit details

   Browse the repository at this point in the history