Commits on May 18, 2020

1. Add deprecation warnings for GraphQLExtension usage. …

   This introduces a deprecation warning which will be emitted once per
   extension which is defined in the `extensions` parameter of an Apollo Server
   configuration.
   
   With the introduction of the last missing integration point
   (`willResolveField`) via the recently landed
   #3988, the new [[Plugin
   API]] should now have all of the abilities (a super-set, in fact) of the
   prior `graphql-extensions` API.
   
   Furthermore, rather than being undocumented, rather untested and largely
   experimental, the new plugin API is considered stable and well-understood in
   terms of what it aims to support.  Its documentation and API are now
   considered part of the Apollo Server API and we will do our best to maintain
   first-class support for it, including the addition of new functionality as
   deemed necessary.
   
   As of this commit, we will now print deprecation warnings one time per
   server start-up for _each_ legacy extension.  Since extensions were often
   defined as factory functions which were invoked on each request - and
   expected to return an instance of the extension by calling `new` on it - we
   limit this deprecation warning to once per start-up by attaching a `Symbol`
   to the `constructor` and skipping the warning when the `Symbol` is already
   present.
   
   An alternative design might use a `Map` to track the `constructor`s at the
   module-level within `requestPipeline.ts`, but I believe this should be
   functionally the same.
   
   [Plugin API]: https://www.apollographql.com/docs/apollo-server/integrations/plugins/

   

   abernix committed May 18, 2020
   Copy the full SHA

   344ae03 View commit details

   Browse the repository at this point in the history