Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository path for graphql-extensions #3881

Merged
merged 2 commits into from Mar 18, 2020
Merged

Fix repository path for graphql-extensions #3881

merged 2 commits into from Mar 18, 2020

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Mar 11, 2020

Avoids links with 404 on npm and yarn websites. Follows package migration to the monorepo.


It'd be great if someone also updated CHANGELOG.md before the next release 🙏 I’m currently seeing that I need to bump from ^0.10.10 to ^0.11.0 and I don’t know if there are any breaking changes to expect.

@kachkaev kachkaev marked this pull request as ready for review March 11, 2020 07:36
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Also, thanks for helping me learn that using directory within repository was a thing!. I had no idea!)

Nothing has changed in graphql-extensions in some time, but it's a dependency of a number of things and internally the Lerna versioning scheme that we use necessitates bumping it unnecessarily sometimes, even when there aren't changes.

That said, we are planning on deprecating graphql-extensions in the next major version of Apollo Server so I would encourage you to explore the new Plugins API that will replace it and trying out that migration!

I hope to be implementing a couple of the missing bits of the new API this week, but aside from willResolveField and requestDidEnd, I don't believe there are any other omissions. In other words, depending on how you're leveraging graphql-extensions today, you'll be more or less successful at that migration. Please feel free to drop a comment here as to how it goes! (Please @ me!)

@abernix abernix merged commit c76441d into apollographql:master Mar 18, 2020
@abernix
Copy link
Member

abernix commented May 14, 2020

@kachkaev Fyi, #3988 has landed and brings graphql-extensions feature complete with the new plugin API. It's in the release-2.14.0 branch right now and published within #4105 (currently on the npm next tag).

@kachkaev kachkaev deleted the patch-1 branch May 15, 2020 21:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants