Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for #3581 - gateway over-merging unions #3616

Merged
merged 2 commits into from Jan 2, 2020
Merged

Cleanup for #3581 - gateway over-merging unions #3616

merged 2 commits into from Jan 2, 2020

Commits on Dec 16, 2019

  1. Gateway over-merging unions cleanup 

    This commit cleans up and simplifies the approach taken by #3581
to prevent the gateway from over-merging fields of unioned types.

The correct information and groupings were already present in the
affected code, they just needed to be utilized correctly. Specifically,
the internal for loop yielding `fieldsForParentType` was not being
used - the less specifically grouped `fieldsForResponseName` was.

Co-authored-by: Tejas Shikhare <tshikhare@netflix.com>
    @trevor-scheer
    trevor-scheer and Tejas Shikhare committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    89cdcfd View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Merge branch 'master' into trevor/gateway-unions-cleanup

    @trevor-scheer
    trevor-scheer committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    e66dc5c View commit details
    Browse the repository at this point in the history