[AS-223] Use forked version of protobufjs #3530
Merged
+34
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernix
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Looks great to me! Thanks for putting this together.
Just leaving some artifacts here in this PR to create references to the commit/line which stepped on Long (d8ade4d#diff-d5d9fcc27f8062d80afd9d8a291b85e6R7) and the PR that introduced it (#2900) for posterity's sake!
We'll want to add a CHANGELOG.md entry before we merge this. I'll suggest this relatively straight-forward and bland wording, but I think it basically encapsulates the change:
- `apollo-engine-reporting`: Swap usage of `protobufjs` for a newly published fork located
at [`@apollo/protobufjs`](https://npm.im/@apollo/protobufjs). This is to account for
the [relative uncertainty](https://github.com/protobufjs/protobuf.js/issues/1199)
into the continued on-going maintenance of the official `protobuf.js` project.
This should immediately resolve a bug that affected `Long` types in
`apollo-engine-reporting` and other non-Apollo projects that rely on `protobuf.js`'s
`Long` type. [PR #3530](https://github.com/apollographql/apollo-server/pull/3530)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a the forked version of protobufjs in Apollo Server (https://github.com/apollographql/protobuf.js)
We want to do this for a few reasons:
first and foremost, a user is suffering from a bug where we override a global property in protobufjs (
longoverride), and they want the default behavior in another package.We want to introduce some functionality to this package soon. (David's PR: Allow plain JS object repeated fields to use toArray() method protobufjs/protobuf.js#1302)