Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose TypeScript types for apollo-server-testing client #2871

Merged
merged 6 commits into from Jun 25, 2019
Merged

expose TypeScript types for apollo-server-testing client #2871

merged 6 commits into from Jun 25, 2019

Conversation

schmod
Copy link
Contributor

@schmod schmod commented Jun 17, 2019

This is a small Pull Request to expose a TypeScript type for the test clients that can be created with the apollo-server-testing client.

@apollo-cla
Copy link

@schmod: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@schmod
Copy link
Contributor Author

schmod commented Jun 18, 2019 •
edited

I'm going to need to run this CLA by some folks.

Would the Apollo folks mind adding this to the documentation and contributor guides? This is one of the stronger CLAs that I've seen, and it's a little awkward being blindsided by it after submitting a Pull Request, as there are definitely folks who aren't going to be able to sign it.

@schmod
Copy link
Contributor Author

schmod commented Jun 19, 2019

CLA signed!

abernix added a commit that referenced this pull request Jun 25, 2019
@abernix
Update CONTRIBUTING.md to forewarn about the CLA requirement.
d767397 
Per the suggestion from @schmod in #2871 (comment), this adds a note that contributors will be expected to sign a Contributor License Agreement (CLA) when contributing to the Apollo Server project.
@abernix
Copy link
Member

abernix commented Jun 25, 2019

Sorry for the blindside! As it notes at the bottom of the agreement (which I know you couldn't have known about ahead of time!), our CLA is derived from the Apache Software Foundation's Individual Contributor License Agreement V2.0. The specific deviations from the original are also itemized there.

That said, I've added a note to the CONTRIBUTING.md in d767397 to make it more clear that the CLA requirement exists. Thanks for pointing that out! :)

abernix
abernix approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit 0939b27 into apollographql:master Jun 25, 2019
@abernix abernix added this to the Release 2.6.6 milestone Jun 25, 2019
@schmod
Copy link
Contributor Author

schmod commented Jun 25, 2019

@abernix Thanks!!! I appreciate the update!

@schmod schmod deleted the test-client-typings branch June 25, 2019 19:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix abernix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmod @apollo-cla @abernix