Cleanup for #3581 - gateway over-merging unions #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up and simplifies the approach taken by #3581 to prevent the gateway from over-merging fields of unioned types. The correct information and groupings were already present in the affected code, they just needed to be utilized correctly. Specifically, the internal for loop yielding `fieldsForParentType` was not being used - the less specifically grouped `fieldsForResponseName` was. Co-authored-by: Tejas Shikhare <tshikhare@netflix.com>
|
@stejas after revisiting your comment, I see what you mean and agree with your suggestion - apologies this took me so long to get around to. I've opened this PR with co-authorship attributed to you in the commit, however if you'd like to update your (current PR)[https://github.com//pull/3457] and land that instead, I'd be happy to do that! Let me know how you'd like to go forward, and thanks again for the contributions! 😊 |
abernix
approved these changes
Dec 31, 2019
|
@trevor-scheer Sorry I missed this, I was on vacation and we don't use github here so I visit it infrequently. Thank you for getting the fix in. |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
This commit cleans up and simplifies the approach taken by apollographql/apollo-server#3581 to prevent the gateway from over-merging fields of unioned types. The correct information and groupings were already present in the affected code, they just needed to be utilized correctly. Specifically, the internal for loop yielding `fieldsForParentType` was not being used - the less specifically grouped `fieldsForResponseName` was. Co-authored-by: Tejas Shikhare <tshikhare@netflix.com> Apollo-Orig-Commit-AS: apollographql/apollo-server@61e6941
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up and simplifies the approach taken by #3581 to prevent the gateway from over-merging fields of unioned types.
The correct information and groupings were already present in the affected code, they just needed to be utilized correctly. Specifically, the internal for loop yielding
fieldsForParentTypewas not being used - the less specifically groupedfieldsForResponseNamewas.