Skip to content

Commit

Permalink
npmignore: Don't include the source of tests
Browse files Browse the repository at this point in the history
We know of no reason that including the source of tests in built npm
packages would be helpful, and we've heard reports that including the
RSA private key fixture as we do in apollo-server-core can trigger
security scans.

Change how we drop tests from "dist" to drop the whole test directory in
case some other files sneak in there.

Add a comment to the one npmignore file that differs from the others.

Fixes #5781.
  • Loading branch information
glasser committed Oct 8, 2021
1 parent f11cd92 commit 71ce883
Show file tree
Hide file tree
Showing 22 changed files with 48 additions and 22 deletions.
3 changes: 2 additions & 1 deletion packages/apollo-datasource-rest/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-datasource/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
7 changes: 6 additions & 1 deletion packages/apollo-reporting-protobuf/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Note that this npmignore file differs from the others because this package
# puts its generated files in "generated" and checks them in to git rather than
# unversioned in "dist".

*
!src/**/*
src/**/__tests__/**
!generated/**/*
generated/**/*.test.*
generated/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-azure-functions/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-cache-memcached/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-cache-redis/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-caching/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-cloud-functions/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-core/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-env/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-errors/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-express/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-fastify/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-hapi/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-integration-testsuite/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-koa/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-lambda/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-micro/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-plugin-base/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-plugin-response-cache/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server-types/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md
3 changes: 2 additions & 1 deletion packages/apollo-server/.npmignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
*
!src/**/*
src/**/__tests__/**
!dist/**/*
dist/**/*.test.*
dist/**/__tests__/**
!package.json
!README.md

0 comments on commit 71ce883

Please sign in to comment.