Skip to content

Commit

Permalink
Use the reportTiming option to disable reporting.
Browse files Browse the repository at this point in the history
Previously, we were leveraging `sendReportsImmediately` to ... do exactly
that even though these tests don't need to send reports _at all_!.  This was
purely a hack to make sure that we don't need to wait for the Engine
Reporting Agent to eventually fail (after 5 seconds or whatever its
reporting interval is).

This new `reportTiming` option is available with the below-linked PR, so we
can now clean this up a bit.  This has the added advantage of not hitting
our actual reporting endpoint with an invalid API key, and having the logs
spew errors about failures in delivering those doomed reports.

Ref: #3918
  • Loading branch information
abernix committed Jun 27, 2020
1 parent 9766f7a commit 53f55d7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('Operation registry plugin', () => {
const hashedApiKey = hashApiKey(apiKey);
const engineOptions: EngineReportingOptions<any> = {
apiKey,
sendReportsImmediately: true,
reportTiming: false,
};
const typeDefs = gql`
type Query {
Expand Down

0 comments on commit 53f55d7

Please sign in to comment.