Skip to content

Commit

Permalink
comment: Add note about typing question and reference to issue.
Browse files Browse the repository at this point in the history
  • Loading branch information
abernix committed May 12, 2020
1 parent db0e378 commit 52418a4
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions packages/apollo-server-plugin-base/src/index.ts
Expand Up @@ -45,6 +45,14 @@ export {
GraphQLRequestContextWillSendResponse,
};

// Typings Note! (Fix in AS3?)
//
// There are a number of types in this module which are specifying `void` as
// their return type, despite the fact that we _are_ observing the value.
// It's possible those should instead be `undefined`. For more details, see
// the issue that was logged as a result of this discovery during (unrelated) PR
// review: https://github.com/apollographql/apollo-server/issues/4103

export interface ApolloServerPlugin<
TContext extends BaseContext = BaseContext
> {
Expand Down

0 comments on commit 52418a4

Please sign in to comment.