Skip to content
This repository was archived by the owner on Apr 14, 2023. It is now read-only.

Update peerDependencies to include qs #1044

Merged
merged 3 commits into from
May 13, 2019
Merged

Update peerDependencies to include qs #1044

merged 3 commits into from
May 13, 2019

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented May 13, 2019

Addresses issue apollographql/apollo-link-rest#187 (comment)

qs is a peer dependency needed by apollo-link-rest so this updates the official docs to reflect that.

TODO:

  • Make sure all of new logic is covered by tests and passes linting
  • Update CHANGELOG.md with your change

Sorry, something went wrong.

@jsjoeio jsjoeio requested review from benjamn and hwillson as code owners May 13, 2019 16:36
Copy link
Contributor

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for taking time out of your day to fix this 💯

CircleCI ran out of memory... We'll probably need another push to rerun it, have no rights there.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented May 13, 2019

No problem! Credit goes to @escapiststupor for pointing this out

@JoviDeCroock
Copy link
Contributor

I can push your changelog entry later tonight, or you can do so yourself if you so please. This will rerun CircleCI so we can merge it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jsjoeio
Copy link
Contributor Author

jsjoeio commented May 13, 2019

I updated the CHANGELOG. Do you mind taking a look to make sure the formatting is okay?

I tried to match the previous entries as best I could.

@codecov-io
Copy link

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1044   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files          22      22           
  Lines        1116    1116           
  Branches      174     174           
======================================
  Hits         1067    1067           
  Misses         44      44           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2fa29...073ba69. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #1044 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1044   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files          22      22           
  Lines        1116    1116           
  Branches      174     162   -12     
======================================
  Hits         1067    1067           
  Misses         44      44           
  Partials        5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2fa29...0ab7e3a. Read the comment docs.

@JoviDeCroock JoviDeCroock merged commit 64a185b into apollographql:master May 13, 2019
@jsjoeio jsjoeio deleted the patch-2 branch May 13, 2019 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants