-
Notifications
You must be signed in to change notification settings - Fork 342
Update peerDependencies to include qs
#1044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot, thanks for taking time out of your day to fix this 💯
CircleCI ran out of memory... We'll probably need another push to rerun it, have no rights there.
No problem! Credit goes to @escapiststupor for pointing this out |
I can push your changelog entry later tonight, or you can do so yourself if you so please. This will rerun CircleCI so we can merge it. |
I updated the CHANGELOG. Do you mind taking a look to make sure the formatting is okay? I tried to match the previous entries as best I could. |
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
======================================
Coverage 95.6% 95.6%
======================================
Files 22 22
Lines 1116 1116
Branches 174 174
======================================
Hits 1067 1067
Misses 44 44
Partials 5 5 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
======================================
Coverage 95.6% 95.6%
======================================
Files 22 22
Lines 1116 1116
Branches 174 162 -12
======================================
Hits 1067 1067
Misses 44 44
Partials 5 5 Continue to review full report at Codecov.
|
Addresses issue apollographql/apollo-link-rest#187 (comment)
qs
is a peer dependency needed byapollo-link-rest
so this updates the official docs to reflect that.TODO: