Sql cache: use a single transaction when using MemoryCache chaining #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
| @@ -43,6 +43,7 @@ actual class SqlNormalizedCacheFactory actual constructor( | |||
| object : AndroidSqliteDriver.Callback(getSchema(withDates)) { | |||
| override fun onConfigure(db: SupportSQLiteDatabase) { | |||
| super.onConfigure(db) | |||
| db.enableWriteAheadLogging() | |||
There was a problem hiding this comment.
What's the impact for existing databases? Can this be enabled on a database that wasn't using WAL previously?
There was a problem hiding this comment.
Maybe turn this into 2 separate PRs? One for transactions, one for WAL?
There was a problem hiding this comment.
I've tested that opening a db created without WAL and enabling WAL on it works without an issue.
Opened a separate PR: #5843
Comment on lines
+111
to
+112
| val changedKeys = records.flatMap { record -> internalMerge(record, cacheHeaders, recordMerger) }.toSet() | ||
| changedKeys + nextCache?.merge(records, cacheHeaders, recordMerger).orEmpty() |
BoD
force-pushed
the
sql-cache-transactions
branch
from
deab18b
to
d271ab7
Compare
martinbonnin
approved these changes
Apr 22, 2024
This was referenced Apr 23, 2024
BoD
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single transaction is used in
merge(records: Collection<Record>), butmerge(record: Record)was called instead when using memory cache chaining, resulting in using 1 transaction per insert (significantly slower).Also - enable WAL by default. This has no noticeable perf impact with the fix above (single transaction), but showed significant improvement without it.(moved to its own PR)Related to #5834