Make enum as sealed class Unknown constructor opt-in #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
I'd vote yes here to make the intent really clear. There might be use cases where opting-in is desirable and we'll guarantee the API while opting-in Maybe Ping @StylianosGakis any preference? |
|
I think a separate annotation makes sense yes. Exactly because it may be something that you may want to opt-in without it being the "wrong" thing to do. While using something ApolloInternal should always be the "wrong" thing to do. |
...tations/src/commonMain/kotlin/com/apollographql/apollo3/annotations/ApolloEnumConstructor.kt
Outdated
Show resolved
Hide resolved
...tations/src/commonMain/kotlin/com/apollographql/apollo3/annotations/ApolloEnumConstructor.kt
Outdated
Show resolved
Hide resolved
…raphql/apollo3/annotations/ApolloEnumConstructor.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
…raphql/apollo3/annotations/ApolloEnumConstructor.kt Co-authored-by: Martin Bonnin <martin@mbonnin.net>
martinbonnin
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5796
This uses
@ApolloInternal- should we introduce a dedicated annotation instead?