Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for Name Too Long violations with responseBased code generation #5480

Closed
wants to merge 33 commits into from
Closed

Workaround for Name Too Long violations with responseBased code generation #5480

wants to merge 33 commits into from

Commits on Dec 13, 2023

  1. Staging the changes which will allow us to include a directive set by… 

    … gradle for making the system ingest a input.json file, which it can then take and create a tree definition of the system as a whole which will allow us to perform a fix for the Name Too Long exceptions in the Apollo system
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f14d88e View commit details
    Browse the repository at this point in the history

  2. Creating the file model for the explicitly remove class which we want… 

    … to extract into a flattened hierarchy
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8007f5c View commit details
    Browse the repository at this point in the history

  3. Implementing the flattening algorithm for ensuring that the system wi… 

    …ll flatten out the modules which we want when the name is too long. System will first check to see if the existing operation or fragment matches the naming convention and then split the IrModelGroups up, and then finally ensure that there are no name collisions.
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    16bfb88 View commit details
    Browse the repository at this point in the history

  4. Creation of a Test suite for the manual flattening based on naming co… 

    …nventions
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    068aa7a View commit details
    Browse the repository at this point in the history

  5. Remove the old tests

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a017ace View commit details
    Browse the repository at this point in the history

  6. Baseline tests for the experimental gradle option

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0543176 View commit details
    Browse the repository at this point in the history

  7. "Fixing lint errors"

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    27a7981 View commit details
    Browse the repository at this point in the history

  8. Creating the baseline test setup for the CodeGen test to include the … 

    …flatten models explicitly setup
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9ebddb9 View commit details
    Browse the repository at this point in the history

  9. Updated the schema and query with a lot of silly names

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a7d0a30 View commit details
    Browse the repository at this point in the history

  10. Query can be query can be added to the query name it isn't good

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    bb9f819 View commit details
    Browse the repository at this point in the history

  11. Query can be query can be added to the query name it isn't good

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5081e2a View commit details
    Browse the repository at this point in the history

  12. Enable the inclusion of Fragmnets in responseBased outputs

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    324391d View commit details
    Browse the repository at this point in the history

  13. Introduce the test JSON

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d796820 View commit details
    Browse the repository at this point in the history

  14. Introduce the expected behavior output

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    51c9da0 View commit details
    Browse the repository at this point in the history

  15. All expected files belong in the com.example package

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9cdf347 View commit details
    Browse the repository at this point in the history

  16. General changes and cleanup

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5e755a9 View commit details
    Browse the repository at this point in the history

  17. Cleanup package names

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    fbdb95d View commit details
    Browse the repository at this point in the history

  18. Updating the fragment files

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    add3d31 View commit details
    Browse the repository at this point in the history

  19. Add in the operationBased tests just to ensure

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8ed94bd View commit details
    Browse the repository at this point in the history

  20. Eliminate the test of java

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5c17853 View commit details
    Browse the repository at this point in the history

  21. No com.example in the expected hierarchy

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9015ae6 View commit details
    Browse the repository at this point in the history

  22. Correct the package names

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    aff7b60 View commit details
    Browse the repository at this point in the history

  23. Replace the version with a version alias

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d30db1d View commit details
    Browse the repository at this point in the history

  24. Compile til it breaks - fixing the test variables

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e97d69f View commit details
    Browse the repository at this point in the history

  25. This test is uncovering all sorts of breaks - building out the nested… 

    … data reactors
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b7b0ed2 View commit details
    Browse the repository at this point in the history

  26. Flatten the adapter

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    1788cac View commit details
    Browse the repository at this point in the history

  27. Fixing code for the fragments as well as updating the cases where we … 

    …need to split up things
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    36e9bc1 View commit details
    Browse the repository at this point in the history

  28. New boolean value

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    5ec4a52 View commit details
    Browse the repository at this point in the history

  29. Updating expected with generated variables

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7047e9b View commit details
    Browse the repository at this point in the history

  30. Updating expected output

    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b5fcf77 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Since we do not expect to support operationBased changes in this gral… 

    …de setup, we can omit them in the test cases
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b4feadd View commit details
    Browse the repository at this point in the history

  2. Updating the pieces for the api changes due to the new flattenExplici… 

    …tly directive
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    db3dea2 View commit details
    Browse the repository at this point in the history

  3. Updating the pieces for the api changes due to the new flattenExplici… 

    …tly directive
    @AdamMTGreenberg
    AdamMTGreenberg committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    152e1bd View commit details
    Browse the repository at this point in the history