Cache: Fix CacheFirst + emitCacheMisses(true) #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record the error handling RFC is here |
|
This has been released as part of v3.7.5 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
emitCacheMisses(true), theCacheFirstfetch policy was never going to the network and therefore could miss some events. This PR adds a test and a fix to continue to the network in case the first response is a cache miss.A huuuuuuuge THANK YOU to @mateuszkwiecinski for all the investigations and to @lwasyl for locating the source of the issue. You rock!
PS: we're hoping to simplify the error handling in 4.x and remove the number of special cases in the interceptors (see this PR). Ping @BoD we should do a small RFC before we're committing to this change to gather community feedback.