Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update one test to play nice with router 1.6.0 #4579

Merged
merged 1 commit into from Dec 16, 2022
Merged

Update one test to play nice with router 1.6.0 #4579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 3 additions & 12 deletions tests/defer/src/commonTest/kotlin/test/DeferWithRouterTest.kt
View file
Open in desktop
Expand Up @@ -199,7 +199,7 @@ class DeferWithRouterTest {

@Test
@Ignore
// TODO Ignored for now, currently the Router doesn't return the __typename on initial payload which breaks parsing - see https://github.com/apollographql/router/issues/1800#issuecomment-1263678302
// TODO Ignored for now, currently the Router doesn't return the __typename on initial payload which breaks parsing - see https://github.com/apollographql/router/issues/1922
fun canDeferFragmentsOnTheTopLevelQueryField() = runTest(before = { setUp() }, after = { tearDown() }) {
// Expected payloads:
// {"data":{"__typename":"Query"},"hasNext":true}
Expand Down Expand Up @@ -365,7 +365,7 @@ class DeferWithRouterTest {
fun handlesNonNullableErrorsThrownOutsideDeferredFragments() = runTest(before = { setUp() }, after = { tearDown() }) {
// Expected payloads:
// {"data":{"computer":null},"errors":[{"message":"Subgraph errors redacted"}],"hasNext":true}
// {"hasNext":false,"incremental":[{"data":null,"path":["computer"]}]}
// {"hasNext":false}
val query = HandlesNonNullableErrorsThrownOutsideDeferredFragmentsQuery()
val uuid = uuid4()

Expand All @@ -388,16 +388,7 @@ class DeferWithRouterTest {
)
)
)
.build(),

ApolloResponse.Builder(
query,
uuid,
data = HandlesNonNullableErrorsThrownOutsideDeferredFragmentsQuery.Data(
null
)
)
.build(),
.build()
)
val actualResponseList = apolloClient.query(query).toFlow().toList()
assertResponseListEquals(expectedDataList, actualResponseList)
Expand Down