Optimize normalization #2860
Merged
Optimize normalization #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sav007
reviewed
Jan 11, 2021
...malized-cache/src/commonMain/kotlin/com/apollographql/apollo/cache/normalized/internal/AJ.kt
Outdated
Show resolved
Hide resolved
sav007
reviewed
Jan 11, 2021
...src/commonMain/kotlin/com/apollographql/apollo/cache/normalized/internal/AJResponseWriter.kt
Outdated
Show resolved
Hide resolved
sav007
reviewed
Jan 11, 2021
...malized-cache/src/commonMain/kotlin/com/apollographql/apollo/cache/normalized/internal/AJ.kt
Outdated
Show resolved
Hide resolved
sav007
reviewed
Jan 12, 2021
| * A hierarchy of Json object with their fields attached used for normalization | ||
| */ | ||
| internal object NormalizationIR { | ||
| sealed class Element { |
There was a problem hiding this comment.
up to you, just a thought if Node suit better?
sav007
approved these changes
Jan 12, 2021
martinbonnin
force-pushed
the
introduce-aj
branch
from
5868152
to
10338a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
NormalizationIRResponseWriter, a ResponseWriter that writes a "normalization IR" later used to compute Records.This removes one intermediate
Mapand tree traversal an makes theapolloParseAndNormalizebenchmark from ~30 to ~22 ms.A nice side effect is that it fixes computing records for Json scalar which didn't work when normalizing models (it works in main when normalizing the network response, see #2859)