Be more robust to publish errors (#2900)

apollographql · Jan 26, 2021 · 63bd112 · 63bd112
1 parent 7bb04c0
commit 63bd112
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/apollo-runtime/src/main/java/com/apollographql/apollo/internal/RealApolloStore.java b/apollo-runtime/src/main/java/com/apollographql/apollo/internal/RealApolloStore.java
@@ -113,8 +113,18 @@ public RealApolloStore(@NotNull NormalizedCache normalizedCache, @NotNull CacheK
       iterableSubscribers = new LinkedHashSet<>(subscribers);
     }
 
+    RuntimeException firstException = null;
     for (RecordChangeSubscriber subscriber : iterableSubscribers) {
-      subscriber.onCacheRecordsChanged(changedKeys);
+      try {
+        subscriber.onCacheRecordsChanged(changedKeys);
+      } catch (RuntimeException e) {
+        if (firstException == null) {
+          firstException = e;
+        }
+      }
+    }
+    if (firstException != null) {
+      throw firstException;
     }
   }