Skip to content

Commit

Permalink
Remove Builders.md as it's mostly outdated and replace by a link in C…
Browse files Browse the repository at this point in the history
…ONTRIBUTING.md (#4588)
  • Loading branch information
martinbonnin committed Dec 16, 2022
1 parent d5ccf9c commit 07154ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 361 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ identifiers and methods are camelCased.

Builders/Constructors

We usually favor Builders for reasons outlined in [this issue](https://github.com/apollographql/apollo-kotlin/issues/3301) unless there is only one optional parameter.

* Use primary constructors with `@JvmOverloads` when there is at most one optional parameter.
* For classes, nest the builder directly under the class
* For interfaces that are meant to be extended by the user but that also have a builtin implementation, you can use
Expand Down
361 changes: 0 additions & 361 deletions design-docs/Builders.md

This file was deleted.

0 comments on commit 07154ef

Please sign in to comment.