Field Merging [3/x] Implement in SelectionSetTemplate #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AnthonyMDev and the rest of your teammates on |
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
561c9c4
to
70ea639
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
d8205b4
to
524a720
Compare
This was referenced Apr 24, 2024
AnthonyMDev
changed the title
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
70ea639
to
36dc2e6
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
524a720
to
5bddba3
Compare
AnthonyMDev
force-pushed
the
03-21-field_merging_2_x_compute_mergedselections_w_mergingstrategy
branch
from
36dc2e6
to
1252393
Compare
AnthonyMDev
force-pushed
the
Implement_FieldMerging_in_SelectionSetTemplate
branch
from
5bddba3
to
288253c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
SelectionSetTemplateto handle different field merging strategies specified in the configuration options. It also refactors the rendering logic to consider merged fields when generating property accessors, fragment accessors, and selection set initializers. This change ensures that the template can handle merged fields appropriately based on the specified merging strategy.