[DRAFT] Schema type renaming #276
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
Adding new IR types to represent schema types
BobaFetters
changed the base branch from
codegen-delete-ccn
to
feature/rename-schema-types
|
Updated this draft with the initial pass at the new IR types to represent the schema types, all changes are under the |
BobaFetters
commented
Feb 23, 2024
apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegen.swift
Outdated
Show resolved
Hide resolved
BobaFetters
commented
Feb 23, 2024
There was a problem hiding this comment.
This file should no longer be needed once this work is complete
BobaFetters
commented
Feb 23, 2024
BobaFetters
commented
Feb 23, 2024
| @@ -0,0 +1,39 @@ | |||
| import Foundation | |||
|
|
|||
| public protocol NamedItem { | |||
There was a problem hiding this comment.
Open to different naming for this protocol.
Redid the new name handling to be on existing GraphQL schema type objects in GraphQLCompiler instead of new IR objects.
…e-types # Conflicts: # apollo-ios-codegen/Sources/ApolloCodegenLib/Templates/InterfaceTemplate.swift
BobaFetters
commented
May 20, 2024
| @@ -224,6 +224,23 @@ class EntitySelectionTree { | |||
| targetSelections.mergeIn(scopeSelections, from: source) | |||
| } | |||
|
|
|||
| if let conditionalScopes = scopeConditions { | |||
There was a problem hiding this comment.
Not sure why these changes are here? Not related to the work I am doing
|
Have this updated with what should be the final implementation for handling schema type renaming after going through a few iterations. Moving on to implementing tests now and will see from there if any further tweaks are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough mvp of one of the approaches to handling custom schema type names to validate path forward before cleaning up code and adding tests etc.