chose(deps): update GraphQLCompiler dependencies #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/package.json
This was referenced Dec 4, 2023
calvincestari
force-pushed
the
deps/secops/graphqlcompiler-2023-12-04
branch
from
ab6ed3f
to
5986f26
Compare
1 task
# Conflicts: # apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript/package.json
calvincestari
force-pushed
the
deps/secops/graphqlcompiler-2023-12-04
branch
from
5d16af5
to
0345195
Compare
calvincestari
commented
Dec 7, 2023
|
|
||
| SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | ||
| output_file="$SCRIPT_DIR/../ApolloCodegenFrontendBundle.swift" | ||
| $( cd "$SCRIPT_DIR" && rollup -c ) | ||
| cd "$SCRIPT_DIR" && npm run build |
There was a problem hiding this comment.
Use the package version of rollup instead of needing a global installation of it.
calvincestari
commented
Dec 7, 2023
| "test": "jest" | ||
| }, | ||
| "engines": { | ||
| "npm": ">=7" | ||
| }, | ||
| "dependencies": { | ||
| "graphql": "17.0.0-alpha.3", | ||
| "graphql": "17.0.0-alpha.2", |
There was a problem hiding this comment.
This is the solution to fixing the Node error in the description. I do not believe we need anything in alpha.3 - all our codegen tests still pass.
AnthonyMDev
approved these changes
Dec 7, 2023
| @@ -207,6 +207,24 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| ./scripts/run-test-codegen-configurations.sh -t | |||
|
|
|||
| verify-frontend-bundle-latest: | |||
There was a problem hiding this comment.
Would it be more efficient to include this as a step in the codegen unit tests CI job instead of spinning up another job? Not sure if it matters since the CI jobs on these runners are free minutes?
BobaFetters
pushed a commit
to apollographql/apollo-ios-codegen
that referenced
this pull request
Dec 7, 2023
BobaFetters
pushed a commit
that referenced
this pull request
Dec 7, 2023
4cc288c4 chose(deps): update GraphQLCompiler dependencies (#181) git-subtree-dir: apollo-ios-codegen git-subtree-split: 4cc288c43509675900fa6c7452ab587fe77efdb9
BobaFetters
pushed a commit
that referenced
this pull request
Dec 7, 2023
…iler dependencies git-subtree-dir: apollo-ios-codegen git-subtree-mainline: ff034f9 git-subtree-split: 4cc288c43509675900fa6c7452ab587fe77efdb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should remain a Draft until there is a resolution to graphql/graphql-js#3927. Until that is resolved the rollup command will fail with the following error:I've downgraded the
graphql-jsdependency to17.0.0-alpha.2to fix the above error. Once there is a resolution to graphql/graphql-js#3927 we can update the graphql-js dependency to the latest available version.Combines the changes from PRs:
Notes:
set -e) which will prevent partial updates to the Swift file which might be perceived as valid changes. I also applied some changes from a Bash script validator.