Guarantee Concast cleanup without Observable cancelled prematurely rejection
#9701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
commented
May 9, 2022
benjamn
added a commit
that referenced
this pull request
May 9, 2022
The Concast class is heavily exercised by much of our test suite, so I would not say it is currently untested, but I would love to expand on these Concast-specific unit tests in the future.
benjamn
force-pushed
the
issue-9690-guarantee-concast-cleanup
branch
from
732e3aa
to
ad31810
Compare
brainkim
approved these changes
May 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @andreialecu's investigations in #9690, I believe we may be close to solving issue #7608 once and for all! 🥳
I can say this with confidence because this PR completely removes the pesky
Observable cancelled prematurelyerror from theConcastimplementation, so it should never again rejectconcast.promise.Instead of terminating remaining
cleanupobservers usingthis.handlers.error(...), I'm now usingthis.handlers.complete()(which required fixing another bug that prevented unsubscribing aftercomplete).