Guide tree-shaking by calling checkDEV() in utilities/globals/index.ts
#8767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually using `checkDEV` by calling it (instead of just re-exporting it) appears to fix the reproduction provided in this comment: #8674 (comment)
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually using
checkDEVby calling it (instead of just re-exporting it) appears to fix the reproduction provided in this comment by @lauraseidler: #8674 (comment)I would have thought the
"sideEffects": trueconfiguration in@apollo/client/utilities/globals/package.jsonwould be enough to keep the modules in@apollo/client/utilities/globals/*from being tree-shaken, but apparently Vite is clever enough to second-guess that guidance when it comes to uncalled function declarations likecheckDEV.Thankfully, we can get away with calling
checkDEV()just this once, in the module that declares/exports it.