Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssrMode #8709

Merged
merged 2 commits into from Aug 27, 2021
Merged

Fix ssrMode #8709

merged 2 commits into from Aug 27, 2021

Conversation

brainkim
Copy link
Contributor

@brainkim brainkim commented Aug 26, 2021 •
edited

hwillson
hwillson approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @brainkim, thanks for digging into this!

@brainkim brainkim requested a review from hwillson August 27, 2021 18:23
benjamn
benjamn reviewed Aug 27, 2021
View reviewed changes
src/core/ApolloClient.ts Outdated Show resolved Hide resolved
@brainkim brainkim force-pushed the brian-ssr-fixes branch 3 times, most recently from 38f159c to 167eee1 Compare August 27, 2021 18:51
@benjamn
Copy link
Member

benjamn commented Aug 27, 2021

@brainkim I like the idea and implementation of a2af729, but unless it's fixing a regression in v3.4.x, I think I'd prefer to move that commit into a new PR targeting release-3.5.

@brainkim
Copy link
Contributor Author

@benjamn Split out the small fixes from the large fixes.

@brainkim brainkim merged commit 120c174 into main Aug 27, 2021
@brainkim brainkim deleted the brian-ssr-fixes branch August 27, 2021 21:06
@brainkim brainkim mentioned this pull request Aug 27, 2021
Closed
benjamn added a commit that referenced this pull request Aug 30, 2021
@benjamn
Subscribe even if client.disableNetworkFetches true in useQuery.
4a0e8dd 
I believe this captures the spirit of #8709, taking the big refactoring
from #8596 into account.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjamn benjamn benjamn left review comments

@hwillson hwillson Awaiting requested review from hwillson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brainkim @benjamn @hwillson