Use setTimeout instead of Promise.resolve().then(...) to delay Concast cancellation
#8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by @cornedor's comment: #7608 (comment) Should help with some instances of issue #7608, specifically those with global unhandled promise rejection errors. I don't know if this is the full solution, but I believe it is helpful and safe to introduce a delay before unsubscribing, giving other subscribers a chance to subscribe, thereby saving the Concast from needing to be cancelled.
brainkim
reviewed
Aug 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by @cornedor's comment #7608 (comment).
Should help with some instances of issue #7608, specifically those with global unhandled promise rejection errors.
I don't know if this is the full solution, but I believe it is helpful and safe to introduce a delay before unsubscribing from the underlying observable, giving other
Concastsubscribers a chance to subscribe, thereby saving theConcastfrom needing to be cancelled, while still quickly unsubscribing if there are no new subscribers within 10ms.