Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to cache.gc to enable deleting nonessential/recomputable result caching data #8421

Merged
merged 10 commits into from
Jul 6, 2021
Merged

Add options to cache.gc to enable deleting nonessential/recomputable result caching data #8421

merged 10 commits into from
Jul 6, 2021

Commits on Jul 6, 2021

  1. Allow specifying canon when creating StoreReader.

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    b8b82c7 View commit details
    Browse the repository at this point in the history

  2. Support cache.gc({ resetResultCache: true }) to jettison result cache.

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    2d20403 View commit details
    Browse the repository at this point in the history

  3. Add options.preserveCanon to cache.gc method.

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    6c7715c View commit details
    Browse the repository at this point in the history

  4. Call cache.init() in cache.restore to reset EntityStore and result ca… 

    …che.

If the cache already has much data in it, the speedup from throwing it
all away before replacing it (and thus not having to delete each entity
one by one) could be pretty significant.
    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    19210de View commit details
    Browse the repository at this point in the history

  5. Mention PR #8421 in CHANGELOG.md.

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    4a85baf View commit details
    Browse the repository at this point in the history

  6. Bump bundlesize limit from 24.4kB to 24.6kB.

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    8fb9f85 View commit details
    Browse the repository at this point in the history

  7. Make StoreReader canon field public. 

    #8421 (comment)
    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    f0fd5e7 View commit details
    Browse the repository at this point in the history

  8. Align naming of resetResultCache and resetResultIdentities. 

    #8421 (comment)
#8421 (comment)
    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    713796a View commit details
    Browse the repository at this point in the history

  9. Add FinalizationRegistry test of cache.gc, and make it pass. 

    #8421 (comment)
    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    10d7558 View commit details
    Browse the repository at this point in the history

  10. Fix comments still mentioning cache.gc({ preserveCanon }).

    @benjamn
    benjamn committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    bb3daf0 View commit details
    Browse the repository at this point in the history