Prevent RenderPromises memory leak by calling renderPromises.clear() after getMarkupFromTree finishes.
#7943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #7942 and the tests I added in my previous commit.
benjamn
changed the title
RenderPromises memory leak by calling renderPromises.clear() after getMarkupFromTree finishes.
benjamn
commented
Apr 2, 2021
Comment on lines
+55
to
+56
| }).finally(() => { | ||
| renderPromises.clear(); |
There was a problem hiding this comment.
We sometimes get complaints about using Promise.prototype.finally from folks who aren't using a polyfill in older browsers, but I think it's fine to use it here, because this is server-side rendering code, which typically runs in Node.js, which has supported Promise.prototype.finally since v8.1.4.
There was a problem hiding this comment.
We could always use try/finally and async/await too :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is my best guess at a reproduction of issue #7942, given the heap snapshots provided by @AlexMost.
As with any
FinalizationRegistry-driven test, the details are tricky, but you can see from the history of this PR that callingrenderPromises.clear()makes the failing test pass consistently.