Provide variables and context to update function #7902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreighton
force-pushed
the
7843-add-context-update-fn
branch
4 times, most recently
from
e4e5eb9
to
6f8dc95
Compare
jcreighton
commented
Apr 2, 2021
brainkim
reviewed
Apr 2, 2021
jcreighton
force-pushed
the
7843-add-context-update-fn
branch
2 times, most recently
from
1d6167f
to
97f13ac
Compare
added 6 commits
April 2, 2021 17:36
jcreighton
force-pushed
the
7843-add-context-update-fn
branch
3 times, most recently
from
4ca6362
to
48a9af4
Compare
jcreighton
force-pushed
the
7843-add-context-update-fn
branch
from
f19c622
to
f79c048
Compare
benjamn
reviewed
Apr 5, 2021
brainkim
approved these changes
Apr 6, 2021
benjamn
reviewed
Apr 9, 2021
benjamn
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Looks great to me!
With any large TS-related change like this, there's some risk of introducing type checking errors for developers using our exported types heavily, or in unusual ways. However, I think that risk is manageable because we're only merging this PR into release-3.4, where it will get released in the next beta version. I'm also working on some v3.4 stuff that interacts with these types, so we'll have plenty of chance to exercise these changes before v3.4 is final.
Feel free to (squash and?) merge whenever you're ready.
Co-authored-by: Ben Newman <ben@apollographql.com>
Co-authored-by: Ben Newman <ben@apollographql.com>
This was referenced Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an enhancement discussed in #7843. A mutation's
updatefunction now receives an optional third argument with the context and variables provided to the original function.Checklist: