-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call nextFetchPolicy
with "variables-changed" even if there is a fetchPolicy
option specified.
#11626
base: main
Are you sure you want to change the base?
Conversation
…etchPolicy` specified. fixes #11365
🦋 Changeset detectedLatest commit: 39737d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
(options.fetchPolicy === oldFetchPolicy || | ||
// A `nextFetchPolicy` function has even higher priority, though, | ||
// so in that case `applyNextFetchPolicy` must be called. | ||
typeof options.nextFetchPolicy === "function") | ||
) { | ||
this.applyNextFetchPolicy("variables-changed", options); | ||
if (newNetworkStatus === void 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that lines 917-920
(
if (newNetworkStatus === void 0) {
newNetworkStatus = NetworkStatus.setVariables;
}
could be removed completely without failing any test. In fact, the new network status is set as part of QueryInfo.init
.
I did not remove it, though, to prevent any unforseen consequences - but wanted to have noted it somewhere.
/release:pr |
A new release has been made for this PR. You can install it with |
fixes #11365