Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restricted-imports-paths eslint rule #11037

Draft
wants to merge 21 commits into
base: release-3.8
Choose a base branch
from

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jul 5, 2023

This PR would add the restricted-imports-paths eslint rule to already indicate the "Risky cross-entry-point nested import of" build warning during development.

Right now, this would also warn on type imports, which we probably don't want to do, and it would need an upstream PR against the lint rule to enable that behaviour.

Before I put more time into this, we should discuss if we see enough benefit in doing this.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 46eb993

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas self-assigned this Jul 6, 2023
Base automatically changed from pr/fileExtensions to release-3.8 August 8, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant