Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify __DEV__ polyfill to use imports instead of global scope #10521

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Simplify __DEV__ polyfill to use imports instead of global scope #10521

merged 6 commits into from
Feb 7, 2023

Commits on Feb 6, 2023

  1. Fix risky internal imports of modules with different package.json.

    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4207078 View commit details
    Browse the repository at this point in the history

  2. Simplify __DEV__ management.

    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    8d5cc20 View commit details
    Browse the repository at this point in the history

  3. Import __DEV__ explicitly where explicitly used.

    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    a044507 View commit details
    Browse the repository at this point in the history

  4. Bump bundlesize limit to 33.7KB (was 33.58KB). 

    See #10521 for
discussion of concerns about this change.
    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    163238b View commit details
    Browse the repository at this point in the history

  5. Simplify utilities/globals/DEV.ts. 

    #10521 (comment)
    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    28ba4e7 View commit details
    Browse the repository at this point in the history

  6. Adding a changeset for the next minor version.

    @benjamn
    benjamn committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    fbf7294 View commit details
    Browse the repository at this point in the history