Reuse diff/lastDiff terminology, instead of newDiff/oldDiff.

https://github.com/apollographql/apollo-client/pull/8000/files/dfe4f290b2ab64c4119981950f6f1195e5b492b3#r616276917
apollographql · Apr 20, 2021 · 875a5af · 875a5af
1 parent 6933b6f
commit 875a5af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/cache/core/types/Cache.ts b/src/cache/core/types/Cache.ts
@@ -4,8 +4,8 @@ import { ApolloCache } from '../cache';
 
 export namespace Cache {
   export type WatchCallback = (
-    newDiff: Cache.DiffResult<any>,
-    oldDiff?: Cache.DiffResult<any>,
+    diff: Cache.DiffResult<any>,
+    lastDiff?: Cache.DiffResult<any>,
   ) => void;
 
   export interface ReadOptions<TVariables = any, TData = any>

diff --git a/src/core/QueryManager.ts b/src/core/QueryManager.ts
@@ -1137,14 +1137,14 @@ export class QueryManager<TStore> {
         // temporary optimistic layer, in case that ever matters.
         removeOptimistic,
 
-        onWatchUpdated: onQueryUpdated && function (watch, newDiff, oldDiff) {
+        onWatchUpdated: onQueryUpdated && function (watch, diff, lastDiff) {
           const oq =
             watch.watcher instanceof QueryInfo &&
             watch.watcher.observableQuery;
 
           if (oq) {
             includedQueriesById.delete(oq.queryId);
-            return maybeAddResult(oq, onQueryUpdated(oq, newDiff, oldDiff));
+            return maybeAddResult(oq, onQueryUpdated(oq, diff, lastDiff));
           }
         },
       });

diff --git a/src/core/types.ts b/src/core/types.ts
@@ -17,8 +17,8 @@ export type QueryListener = (queryInfo: QueryInfo) => void;
 
 export type OnQueryUpdated<TData> = (
   observableQuery: ObservableQuery,
-  newDiff: Cache.DiffResult<TData>,
-  oldDiff?: Cache.DiffResult<TData>,
+  diff: Cache.DiffResult<TData>,
+  lastDiff?: Cache.DiffResult<TData>,
 ) => boolean | Promise<ApolloQueryResult<TData>>;
 
 export type OperationVariables = Record<string, any>;