Make StoreReader canon field public.

#8421 (comment)
apollographql · Jun 28, 2021 · 1360139 · 1360139
1 parent bb09653
commit 1360139
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/cache/inmemory/__tests__/cache.ts b/src/cache/inmemory/__tests__/cache.ts
@@ -1347,7 +1347,7 @@ describe('Cache', () => {
       const originalMBW = cache["maybeBroadcastWatch"];
       expect(typeof originalMBW).toBe("function");
 
-      const originalCanon = originalReader["canon"];
+      const originalCanon = originalReader.canon;
       expect(originalCanon).toBeInstanceOf(ObjectCanon);
 
       cache.writeQuery({
@@ -1379,7 +1379,7 @@ describe('Cache', () => {
       expect(originalMBW).not.toBe(cache["maybeBroadcastWatch"]);
       // The cache.storeReader.canon is preserved by default, but can be dropped
       // by passing preserveCanon:false to cache.gc.
-      expect(originalCanon).toBe(cache["storeReader"]["canon"]);
+      expect(originalCanon).toBe(cache["storeReader"].canon);
     });
   });
 

diff --git a/src/cache/inmemory/__tests__/readFromStore.ts b/src/cache/inmemory/__tests__/readFromStore.ts
@@ -2025,7 +2025,7 @@ describe('reading from the store', () => {
       },
     });
 
-    const canon = cache["storeReader"]["canon"];
+    const canon = cache["storeReader"].canon;
 
     const query = gql`
       query {
@@ -2081,7 +2081,7 @@ describe('reading from the store', () => {
       },
     });
 
-    const canon = cache["storeReader"]["canon"];
+    const canon = cache["storeReader"].canon;
 
     const fragment = gql`
       fragment CountFragment on Query {

diff --git a/src/cache/inmemory/inMemoryCache.ts b/src/cache/inmemory/inMemoryCache.ts
@@ -124,7 +124,7 @@ export class InMemoryCache extends ApolloCache<NormalizedCacheObject> {
         canon: (
           preserveCanon &&
           previousReader &&
-          previousReader["canon"]
+          previousReader.canon
         ) || void 0,
       }),
     );

diff --git a/src/cache/inmemory/readFromStore.ts b/src/cache/inmemory/readFromStore.ts
@@ -129,12 +129,12 @@ export class StoreReader {
     resultCacheMaxSize?: number;
   };
 
-  private canon: ObjectCanon;
-
   private knownResults = new (
     canUseWeakMap ? WeakMap : Map
   )<Record<string, any>, SelectionSetNode>();
 
+  public canon: ObjectCanon;
+
   constructor(config: StoreReaderConfig) {
     this.config = {
       ...config,