chore: use Google Java Format to format Java code automaticlly by github action #4200

Anilople · 2022-01-08T14:21:06Z

What's the purpose of this PR

Auto format Java code when people push or pull request.

Which issue(s) this PR fixes:

Fixes #4196

Brief changelog

Add a workflow .github/workflows/google-java-format.yml

Follow this checklist to help us incorporate your contribution quickly and easily:

Read the Contributing Guide before making this pull request.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit tests to verify the code.
Run mvn clean test to make sure this pull request doesn't break anything.
Update the CHANGES log.

github-actions · 2022-01-08T14:21:25Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

codecov-commenter · 2022-01-08T14:26:44Z

Codecov Report

Merging #4200 (16c62bc) into master (96ee53a) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 16c62bc differs from pull request most recent head 1d73cc1. Consider uploading reports for the commit 1d73cc1 to get more accurate results

@@             Coverage Diff              @@
##             master    #4200      +/-   ##
============================================
+ Coverage     52.56%   52.58%   +0.01%     
- Complexity     2623     2625       +2     
============================================
  Files           484      484              
  Lines         15200    15200              
  Branches       1571     1571              
============================================
+ Hits           7990     7993       +3     
+ Misses         6651     6650       -1     
+ Partials        559      557       -2

Impacted Files	Coverage Δ
.../framework/apollo/spring/property/SpringValue.java	`89.47% <0.00%> (+1.75%)`	⬆️
...rk/apollo/spring/property/SpringValueRegistry.java	`89.18% <0.00%> (+5.40%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ee53a...1d73cc1. Read the comment docs.

Anilople · 2022-01-08T14:29:43Z

@apolloconfig/committers

Is it possible let @github-actions sign the CLA?

zouyx · 2022-01-10T15:22:51Z

@apolloconfig/committers

Is it possible let @github-actions sign the CLA?

What about add github-actions to this JSON file directly？

nobodyiam · 2022-01-11T01:11:44Z

@apolloconfig/committers

Is it possible let @github-actions sign the CLA?

@Anilople @zouyx We could add github-actions to allowlist as shown below to skip cla check.

apollo/.github/workflows/cla.yml

Line 40 in 0e4542e

allowlist: dependabot,bot*

Anilople · 2022-01-11T13:01:28Z

@apolloconfig/committers
Is it possible let @github-actions sign the CLA?

@Anilople @zouyx We could add github-actions to allowlist as shown below to skip cla check.

apollo/.github/workflows/cla.yml

Line 40 in 0e4542e

allowlist: dependabot,bot*

Done.

nobodyiam · 2022-01-12T00:51:47Z

@Anilople It looks like we need to submit a standalone pull request to add github-actions to allowlist first or it won't be effective for this pull request.

nobodyiam · 2022-01-12T14:21:56Z

recheck

...ce/src/main/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceAcquireLockAspect.java

...service/src/main/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceUnlockAspect.java

…formatting

nobodyiam · 2022-01-16T04:32:47Z

...dminservice/src/test/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceLockTest.java

-  @Mock
-  private NamespaceLockService namespaceLockService;
-  @Mock
-  private NamespaceService namespaceService;
-  @Mock
-  private ItemService itemService;
-  @Mock
-  private BizConfig bizConfig;
-  @InjectMocks
-  NamespaceAcquireLockAspect namespaceLockAspect;
+  @Mock private NamespaceLockService namespaceLockService;
+  @Mock private NamespaceService namespaceService;
+  @Mock private ItemService itemService;
+  @Mock private BizConfig bizConfig;
+  @InjectMocks NamespaceAcquireLockAspect namespaceLockAspect;


Is it possible to keep the annotations on top of the fields?

Find the issue google/google-java-format#648 about it.

It seem that this feature didn't support yet.

Maybe we can wait the feature.

emm...I think this is an important feature as most of the developers would be more comfortable with the annotation in its own line?

stale · 2022-02-17T03:12:53Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale · 2022-03-23T15:01:32Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

stale · 2022-04-23T11:41:09Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 14 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Anilople added the chore Project chores such as CI settings, typos, etc. label Jan 8, 2022

Anilople closed this Jan 11, 2022

Anilople reopened this Jan 11, 2022

github-actions bot locked and limited conversation to collaborators Jan 11, 2022

Anilople closed this Jan 11, 2022

Anilople reopened this Jan 11, 2022

apolloconfig unlocked this conversation Jan 12, 2022

Anilople mentioned this pull request Jan 12, 2022

build: add github-actions to CLAssistant's allowlist #4205

Merged

5 tasks

nobodyiam closed this in #4205 Jan 12, 2022

github-actions bot locked and limited conversation to collaborators Jan 12, 2022

nobodyiam reopened this Jan 12, 2022

apolloconfig unlocked this conversation Jan 12, 2022

Anilople force-pushed the build/google-java-format branch from 4d6726c to d18067b Compare January 14, 2022 15:25

Anilople added 2 commits January 14, 2022 23:30

build: Google Java Format action

b6c2d4c

Update CHANGES.md

1965838

Anilople force-pushed the build/google-java-format branch from 131dcb7 to 1965838 Compare January 14, 2022 15:32

nobodyiam reviewed Jan 15, 2022

View reviewed changes

...ce/src/main/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceAcquireLockAspect.java Outdated Show resolved Hide resolved

nobodyiam reviewed Jan 15, 2022

View reviewed changes

...service/src/main/java/com/ctrip/framework/apollo/adminservice/aop/NamespaceUnlockAspect.java Outdated Show resolved Hide resolved

chore: java code format --skip-reflowing-long-strings --skip-javadoc-…

16c62bc

…formatting

Anilople force-pushed the build/google-java-format branch from 948b725 to 16c62bc Compare January 16, 2022 02:29

chore: Google Java Format

1d73cc1

nobodyiam reviewed Jan 16, 2022

View reviewed changes

stale bot added the stale label Feb 17, 2022

Anilople removed the stale label Feb 21, 2022

stale bot added the stale label Mar 23, 2022

Anilople removed the stale label Mar 24, 2022

stale bot added the stale label Apr 23, 2022

nobodyiam added enhancement and removed stale labels Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: use Google Java Format to format Java code automaticlly by github action #4200

chore: use Google Java Format to format Java code automaticlly by github action #4200

Anilople commented Jan 8, 2022 •

edited

github-actions bot commented Jan 8, 2022 •

edited

codecov-commenter commented Jan 8, 2022 •

edited

Anilople commented Jan 8, 2022

zouyx commented Jan 10, 2022 •

edited

nobodyiam commented Jan 11, 2022

Anilople commented Jan 11, 2022

nobodyiam commented Jan 12, 2022

nobodyiam commented Jan 12, 2022

nobodyiam Jan 16, 2022

Anilople Jan 17, 2022

nobodyiam Jan 18, 2022 •

edited

stale bot commented Feb 17, 2022

stale bot commented Mar 23, 2022

stale bot commented Apr 23, 2022

chore: use Google Java Format to format Java code automaticlly by github action #4200

Are you sure you want to change the base?

chore: use Google Java Format to format Java code automaticlly by github action #4200

Conversation

Anilople commented Jan 8, 2022 • edited

What's the purpose of this PR

Which issue(s) this PR fixes:

Brief changelog

github-actions bot commented Jan 8, 2022 • edited

codecov-commenter commented Jan 8, 2022 • edited

Codecov Report

Anilople commented Jan 8, 2022

zouyx commented Jan 10, 2022 • edited

nobodyiam commented Jan 11, 2022

Anilople commented Jan 11, 2022

nobodyiam commented Jan 12, 2022

nobodyiam commented Jan 12, 2022

nobodyiam Jan 16, 2022

Choose a reason for hiding this comment

Anilople Jan 17, 2022

Choose a reason for hiding this comment

nobodyiam Jan 18, 2022 • edited

Choose a reason for hiding this comment

stale bot commented Feb 17, 2022

stale bot commented Mar 23, 2022

stale bot commented Apr 23, 2022

Anilople commented Jan 8, 2022 •

edited

github-actions bot commented Jan 8, 2022 •

edited

codecov-commenter commented Jan 8, 2022 •

edited

zouyx commented Jan 10, 2022 •

edited

nobodyiam Jan 18, 2022 •

edited