Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

using new deployment tool, launchpad #1

Closed
wants to merge 3 commits into from

Conversation

kidiyoor
Copy link

@kidiyoor kidiyoor commented Feb 2, 2017

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rohan-m
Copy link
Member

rohan-m commented Sep 28, 2017

@malagappan @rupam-rai I believe most of the changes here is a replication of #4

Copy link
Contributor

@malagappan malagappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json - launchpad is an npm module right, do we have to do add dependency to github directly. bugs/homepage points to a specific users fork.
request - version; I see the version changed to 2.81 in openbank from 2.69; you might want to check it out.
config.yml - had mention of bank, and collection permissions were wrong;
Redirect-Login-Application.xml - does the redirect work? sessionId is missing in the url - not sure whether corresponding changes are done in rest of the code.

@rohan-m
Copy link
Member

rohan-m commented Sep 28, 2017

request module version changed from "^2.69.0" to "2.81.0" in all the repo's.
"2.81.0" is the latest version which does not break the build.
semver minor versioning is broken. Please refer - request/request#2772

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants