Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fixes format validation #199 #200

Merged
merged 3 commits into from
May 10, 2023
Merged

bug: fixes format validation #199 #200

merged 3 commits into from
May 10, 2023

Conversation

srinandan
Copy link
Collaborator

No description provided.

@ssvaidyanathan ssvaidyanathan requested review from kurtkanaskie and removed request for ssvaidyanathan May 9, 2023 16:33
@kurtkanaskie
Copy link
Collaborator

The fix for CircularReferenceCounter is not sufficient.

The value should be larger: openapi3.CircularReferenceCounter = 20

It also needs to be added to LoadDocumentFromURI

Copy link
Collaborator

@kurtkanaskie kurtkanaskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be greater than 10, I suggest 20.

Also needs to be added to LoadDocumentFromURI

internal/bundlegen/generateapi.go Outdated Show resolved Hide resolved
@srinandan srinandan linked an issue May 10, 2023 that may be closed by this pull request
@srinandan srinandan merged commit 6892382 into main May 10, 2023
5 checks passed
@srinandan srinandan deleted the issue199 branch May 10, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An OAS with circular schema definitions fails to create API proxy
2 participants