Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ContainerBuilder::addRemovedBindingId to ContainerBuilder::removeBindings #2750

Merged
merged 1 commit into from
Apr 27, 2019
Merged

Rename ContainerBuilder::addRemovedBindingId to ContainerBuilder::removeBindings #2750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ parameters:
message: '#Method ApiPlatform\\Core\\Bridge\\Doctrine\\Orm\\Util\\QueryBuilderHelper::mapJoinAliases() should return array<string, array<string>\|string> but returns array<int|string, mixed>\.#'
path: %currentWorkingDirectory%/src/Bridge/Doctrine/Orm/Util/QueryBuilderHelper.php
-
message: "#Call to function method_exists\\(\\) with 'Symfony\\\\\\\\Component.+' and 'addRemovedBindingIds?' will always evaluate to false\\.#"
message: "#Call to function method_exists\\(\\) with 'Symfony\\\\\\\\Component.+' and '(removeBindings|addRemovedBindingIds)' will always evaluate to false\\.#"
path: %currentWorkingDirectory%/tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
- "#Call to method PHPUnit\\\\Framework\\\\Assert::assertSame\\(\\) with array\\('(collection_context|item_context|subresource_context)'\\) and array<Symfony\\\\Component\\\\VarDumper\\\\Cloner\\\\Data>\\|bool\\|float\\|int\\|string\\|null will always evaluate to false\\.#"
# https://github.com/doctrine/doctrine2/pull/7298/files
Expand Down
6 changes: 3 additions & 3 deletions tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,10 +845,10 @@ private function getPartialContainerBuilderProphecy()

// irrelevant, but to prevent errors
// https://github.com/symfony/symfony/pull/29944
if (method_exists(ContainerBuilder::class, 'addRemovedBindingId')) {
$containerBuilderProphecy->addRemovedBindingId(Argument::type('string'))->will(function () {});
if (method_exists(ContainerBuilder::class, 'removeBindings')) {
$containerBuilderProphecy->removeBindings(Argument::type('string'))->will(function () {});
} elseif (method_exists(ContainerBuilder::class, 'addRemovedBindingIds')) {
// https://github.com/symfony/symfony/pull/31173
// remove this once https://github.com/symfony/symfony/pull/31173 is released
$containerBuilderProphecy->addRemovedBindingIds(Argument::type('string'))->will(function () {});
}

Expand Down