Removes experimental_http3 as now standard #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental_http3 server protocol option is now failing in Caddyfile as the option has been removed. HTTP/3 support is now standard. See caddyserver/caddy#4707
|
I guess we might be able to remove the entire |
|
Yes please remove the entire block as well as the related comment! Thank you |
This block is now, no longer required.
|
Done! |
dunglas
approved these changes
Sep 21, 2022
|
Thanks @toby-griffiths |
BurningDog
added a commit
to BurningDog/api-platform-3.x
that referenced
this pull request
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental_http3 server protocol option is now failing in Caddyfile as the option has been removed.
HTTP/3 support is now standard.
See…
It appears that support for the experimental_http3 server protocol option has been removed from Caddy. This PR shows that the default options now include h3 (HTTP/3).
I'm not sure how I would 'test' this, other than have existing tests pass as the server won't now run without this change?! Please advise if more is needed here.