Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4409 NullPointerException in SendAckRequestProcessor #2163

Merged
merged 1 commit into from
May 2, 2024
Merged

ZOOKEEPER-4409 NullPointerException in SendAckRequestProcessor #2163

merged 1 commit into from
May 2, 2024

Conversation

zouyonghao
Copy link
Contributor

No description provided.

@zouyonghao zouyonghao mentioned this pull request May 1, 2024
Closed
eolivelli
eolivelli approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cnauroth
cnauroth approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

On #1774, I mentioned that there might still be a concurrency issue, but no objection to committing this as a first pass.

@zouyonghao , thank you for your testing and your patience working with the community on this patch!

@zouyonghao
Copy link
Contributor Author

+1

On #1774, I mentioned that there might still be a concurrency issue, but no objection to committing this as a first pass.

@zouyonghao , thank you for your testing and your patience working with the community on this patch!

Thanks! I already knew that it’s hard to accept patches for open source projects especially for a large project based on my previous experience of submitting patches. So, it’s fine for me…

@tisonkun
Copy link
Member

tisonkun commented May 2, 2024

Thanks for your contribution! This patch looks correct literally.

@tisonkun tisonkun merged commit 9b81d10 into apache:master May 2, 2024
13 checks passed
@eolivelli
Copy link
Contributor

I am cherry-picking to branch-3.9

eolivelli pushed a commit that referenced this pull request May 2, 2024
@zouyonghao @eolivelli
ZOOKEEPER-4409 NullPointerException in SendAckRequestProcessor (#2163)
ee81bef 
(cherry picked from commit 9b81d10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnauroth cnauroth cnauroth approved these changes

@eolivelli eolivelli eolivelli approved these changes

@tisonkun tisonkun tisonkun approved these changes

@ztzg ztzg Awaiting requested review from ztzg

@anmolnar anmolnar Awaiting requested review from anmolnar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@zouyonghao @tisonkun @eolivelli @cnauroth