-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINOR] Fix deployment issues #4749
base: master
Are you sure you want to change the base?
[MINOR] Fix deployment issues #4749
Conversation
</plugin> | ||
<plugin> | ||
<artifactId>maven-shade-plugin</artifactId> | ||
<configuration> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the effect of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When publishing all interpreters including shell, maven-shade-plugin
makes a fatjar and copies it into interpreter
directory. maven-resource-plugin
works similarly except for copying configurations to the directory.
FYI,
zeppelin/zeppelin-interpreter-parent/pom.xml
Lines 110 to 164 in f2253f1
<!-- generate interpreter shade jar and put it under folder interpreter/${interpreter.name}--> | |
<plugin> | |
<groupId>org.apache.maven.plugins</groupId> | |
<artifactId>maven-shade-plugin</artifactId> | |
<configuration> | |
<createDependencyReducedPom>false</createDependencyReducedPom> | |
<filters> | |
<filter> | |
<artifact>*:*</artifact> | |
<excludes> | |
<exclude>META-INF/*.SF</exclude> | |
<exclude>META-INF/*.DSA</exclude> | |
<exclude>META-INF/*.RSA</exclude> | |
<exclude>org.apache.zeppelin:zeppelin-interpreter-shaded</exclude> | |
</excludes> | |
</filter> | |
</filters> | |
<transformers> | |
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" /> | |
<transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer"> | |
<resource>reference.conf</resource> | |
</transformer> | |
</transformers> | |
<artifactSet> | |
<excludes> | |
<exclude>org.apache.zeppelin:zeppelin-interpreter-shaded</exclude> | |
</excludes> | |
</artifactSet> | |
<outputFile>${project.basedir}/../interpreter/${interpreter.name}/${project.artifactId}-${project.version}.jar</outputFile> | |
</configuration> | |
<executions> | |
<execution> | |
<phase>package</phase> | |
<goals> | |
<goal>shade</goal> | |
</goals> | |
</execution> | |
</executions> | |
</plugin> | |
<plugin> | |
<artifactId>maven-resources-plugin</artifactId> | |
<executions> | |
<execution> | |
<id>copy-interpreter-setting</id> | |
<phase>package</phase> | |
<goals> | |
<goal>resources</goal> | |
</goals> | |
<configuration> | |
<outputDirectory>${project.build.directory}/../../interpreter/${interpreter.name}</outputDirectory> | |
</configuration> | |
</execution> | |
</executions> | |
</plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the whole sh
dir disappears in the interpreter
folder, not only "configurations", is it expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct. Shell interpreter was and will be removed from the official binary because it lead a lot of security issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it's the expected behavior. Test may need to be adjusted to adapt this change.
There are a lot of test failures. Let me fix it one by one soon |
What is this PR for?
Fixing some issues that happened when releasing.
What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
N/A
How should this be tested?
Distribution and building docker image should work fine.
Screenshots (if appropriate)
Questions: