New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix Lint Issue #8185
[CI] Fix Lint Issue #8185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mehrdadh
Thank you @mehrdadh the PR has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry or the late review, but this PR was submitted and merged before I had a chance to have a look :).
I looked into this issue a few days back, in the context of #8089. This only reproduces once black
is updated to the latest version.
I think it would be important to send a PR fixing all the files for new linting issues black
find, especially the ones that look like the ones sent here, which will happen all over the Python codebase (the root cause is this update on black
- https://github.com/psf/black/pull/1740
). Otherwise, we'll have lots of patches which claim they are doing something, and are also including lots of small docstring format updates, which can be confusing.
What do you think?
@leandron I had to send a quick fix since two other PRs were waiting on it. But I agree with you that we should reformat all files with new changes to avoid these small changes. |
follow up: #8194 |
We need to set
LC_ALL
andLANG
before running anyblack
command otherwise it has error.