Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix Lint Issue #8185

Merged
merged 1 commit into from Jun 3, 2021
Merged

[CI] Fix Lint Issue #8185

merged 1 commit into from Jun 3, 2021

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jun 3, 2021

We need to set LC_ALL and LANG before running any black command otherwise it has error.

@mehrdadh
Copy link
Member Author

mehrdadh commented Jun 3, 2021

@areusch @tqchen

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mehrdadh

@tmoreau89 tmoreau89 merged commit b753772 into apache:main Jun 3, 2021
@tmoreau89
Copy link
Contributor

Thank you @mehrdadh the PR has been merged

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry or the late review, but this PR was submitted and merged before I had a chance to have a look :).

I looked into this issue a few days back, in the context of #8089. This only reproduces once black is updated to the latest version.

I think it would be important to send a PR fixing all the files for new linting issues black find, especially the ones that look like the ones sent here, which will happen all over the Python codebase (the root cause is this update on black - https://github.com/psf/black/pull/1740). Otherwise, we'll have lots of patches which claim they are doing something, and are also including lots of small docstring format updates, which can be confusing.

What do you think?

@mehrdadh mehrdadh deleted the fix_lint branch June 4, 2021 16:09
@mehrdadh
Copy link
Member Author

mehrdadh commented Jun 4, 2021

@leandron I had to send a quick fix since two other PRs were waiting on it. But I agree with you that we should reformat all files with new changes to avoid these small changes.
I'll send a PR soon and fix all of the files and I will ping you for review.
Thanks!

@mehrdadh
Copy link
Member Author

mehrdadh commented Jun 4, 2021

follow up: #8194

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants