Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pylint] Making hexagon tests pylint compliant Part 1 of N #12082

Merged
merged 3 commits into from Jul 19, 2022
Merged

[Pylint] Making hexagon tests pylint compliant Part 1 of N #12082

merged 3 commits into from Jul 19, 2022

Conversation

quic-sanirudh
Copy link
Contributor

@quic-sanirudh quic-sanirudh commented Jul 13, 2022 •
edited

This is the first of a few PRs I'll raise to update the hexagon tests pylint compliant.

This patch fixes the below 7 files

  • tests/python/contrib/test_hexagon/benchmark_elemwise_add.py
  • tests/python/contrib/test_hexagon/benchmark_util.py
  • tests/python/contrib/test_hexagon/conftest.py
  • tests/python/contrib/test_hexagon/conv2d/test_conv2d_blocked.py
  • tests/python/contrib/test_hexagon/conv2d/test_conv2d_conv2d.py
  • tests/python/contrib/test_hexagon/infrastructure.py
  • tests/python/contrib/test_hexagon/test_2d_physical_buffers.py

This is part of the larger effort tracked in #11414 to make all tests in TVM pylint compliant

@quic-sanirudh quic-sanirudh mentioned this pull request Jul 13, 2022
Open
@quic-sanirudh
Copy link
Contributor Author

quic-sanirudh commented Jul 14, 2022 •
edited

@mehrdadh @cconvey @adstraw Could you take a look at this PR to make the tests pylint compliant when you get a chance. Based on git history, I saw that the 3 of you are the top authors to these files, so I thought I'll request your help in reviewing this.

@areusch areusch requested a review from mehrdadh July 14, 2022 19:41
Mousius
Mousius requested changes Jul 18, 2022
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, just a few questions around the exclusions - overall a positive step @quic-sanirudh 😸

tests/python/contrib/test_hexagon/test_benchmark_elemwise_add.py Outdated Show resolved Hide resolved
tests/python/contrib/test_hexagon/test_2d_physical_buffers.py Outdated Show resolved Hide resolved
tests/python/contrib/test_hexagon/test_2d_physical_buffers.py Show resolved Hide resolved
tests/python/contrib/test_hexagon/test_benchmark_elemwise_add.py Outdated Show resolved Hide resolved
@Mousius Mousius merged commit 7159ddd into apache:main Jul 19, 2022
@Mousius
Copy link
Member

Mousius commented Jul 19, 2022

Landing this as it's a great step towards linted tests - thanks @quic-sanirudh!

@quic-sanirudh quic-sanirudh deleted the fix_linter_hexagon_tests branch July 20, 2022 03:47
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@quic-sanirudh @xinetzone
[Pylint] Making hexagon tests pylint compliant Part 1 of N (apache#12082
8bde4f6 
)
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
@quic-sanirudh
[Pylint] Making hexagon tests pylint compliant Part 1 of N (apache#12082
779917a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mousius Mousius Mousius approved these changes

@mehrdadh mehrdadh Awaiting requested review from mehrdadh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quic-sanirudh @Mousius