Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making CMSIS-NN tests pylint compliant #11625

Merged
merged 3 commits into from Jun 9, 2022

Conversation

ashutosh-arm
Copy link
Contributor

This commit fixes pylint issues with CMSIS-NN
tests reported in #11414

@ashutosh-arm
Copy link
Contributor Author

cc: @Mousius @areusch for code review.

@ashutosh-arm
Copy link
Contributor Author

ashutosh-arm commented Jun 9, 2022

@Mousius I've addressed review comments related to the code commenting disabling long lines and function without a return (mixed return/no-return statements). Thanks for helping out.

@Mousius Mousius self-requested a review June 9, 2022 13:01
Change-Id: I6bc536a80a24a1603e9f75f8ee9a26d0d88f10df
Change-Id: Iee513a4a5bef1db5b78e1d25a30ac7202f8b0e92
Change-Id: Iff029c3899b289f0c7aaf80ba6c2b648c6ba33eb
@Mousius Mousius merged commit 81b42e6 into apache:main Jun 9, 2022
@Mousius
Copy link
Member

Mousius commented Jun 9, 2022

Great work @ashutosh-arm!

Kathryn-cat pushed a commit to Kathryn-cat/tvm that referenced this pull request Jun 10, 2022
juda pushed a commit to juda/tvm that referenced this pull request Jun 21, 2022
@ashutosh-arm ashutosh-arm deleted the pylint_cmsisnn branch August 31, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants