Enable pylint for the python tests

[gigiblender]

This PR enables pylint for the tests and addresses #11414.

There is a large number of tests that have formatting errors. See the file attached.

out.txt

[Mousius]

@gigiblender is there anyway to make it error for new tests?

[gigiblender]

@Mousius I don't see a clean way to do this.

We could have a temporary pylintrc file, used only for the tests, that passes the list in #11414 as the ignore parameter.. However, new tests in existing files would also be ignored in this case.

[Mousius]

@Mousius I don't see a clean way to do this.

We could have a temporary pylintrc file, used only for the tests, that passes the list in #11414 as the ignore parameter.. However, new tests in existing files would also be ignored in this case.

Hmmm, I'm unsure whether we want to fill the logs with pylint without actually halting the build? Methinks it's worth doing as you suggested and filtering out the files we know will fail - we then have to lint them ourselves as quickly as we can 😿

[gigiblender]

@Mousius I don't see a clean way to do this.
We could have a temporary pylintrc file, used only for the tests, that passes the list in #11414 as the ignore parameter.. However, new tests in existing files would also be ignored in this case.

Hmmm, I'm unsure whether we want to fill the logs with pylint without actually halting the build? Methinks it's worth doing as you suggested and filtering out the files we know will fail - we then have to lint them ourselves as quickly as we can crying_cat_face

@Mousius, I applied your suggestion. Please have a look when you get the time.

[Mousius]

Argh @gigiblender, I didn't realise we would only be able to specify test_pooling.py, that means test_cmsisnn is ignored by mistake in the last test block - ideally we'd disable all of them and then enable them as we merge PRs to fix them, unsure if we can do that or if we just have to keep adding directories to the list and clean up later 🤔 any ideas @gigiblender ?

[gigiblender]

@Mousius, I think the second option sounds better. We can add subdirectories to the list as we fix them and collapse the list in a single entry once all the tests pass the linter. I think I can close this PR.

[Mousius]

Sounds good to me @gigiblender, thanks for raising this and kickstarting the great linting of 2022!