Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated node version from 18 to 20 #8009

Merged
merged 6 commits into from
May 21, 2024

Conversation

rimashah25
Copy link
Contributor

Upgrading node version to 20.11.0


Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Automation (GitHub Actions)

What is the best way to verify this PR?

Pass all GH actions

If this is a bugfix, which Traffic Control versions contained the bug?

N/A

PR submission checklist

@rimashah25 rimashah25 added low impact affects only a small portion of a CDN, and cannot itself break one cdn-in-a-box related to the Docker-based CDN-in-a-Box system dependencies Pull requests that update a dependency file Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels May 14, 2024
@zrhoffman
Copy link
Member

zrhoffman commented May 20, 2024

Looking at the end-to-end tests run (under Run everything and test):

  │ Cypress:        13.6.2                                                                         │
  │ Browser:        Electron 114 (headless)                                                        │
  │ Node Version:   v18.20.2 (/usr/local/bin/node)                                                 │

so it's still using Node 18 for the end-to-end tests, but it should use Node 20 instead.

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These titles:

should be changed to

      - name: Node ${{ env.NODE_VERSION }}

experimental/traffic-portal/build/traffic_portal_v2.spec Outdated Show resolved Hide resolved
experimental/traffic-portal/package.json Outdated Show resolved Hide resolved
experimental/traffic-portal/build/package.json Outdated Show resolved Hide resolved
.github/workflows/tpv2.yml Outdated Show resolved Hide resolved
.github/workflows/tpv2.yml Outdated Show resolved Hide resolved
@rimashah25
Copy link
Contributor Author

These titles:

should be changed to

      - name: Node ${{ env.NODE_VERSION }}

Fixed in c44f5aa

@rimashah25 rimashah25 requested a review from zrhoffman May 21, 2024 15:48
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end-to-end tests fail in CDN-in-a-Box
tpv2-e2e-test-1    | Opening Cypress...
tpv2-e2e-test-1    |
tpv2-e2e-test-1    | tput: No value for $TERM and no -T specified
tpv2-e2e-test-1    | ================================================================================
tpv2-e2e-test-1    |
tpv2-e2e-test-1    |   (Run Starting)
tpv2-e2e-test-1    |
tpv2-e2e-test-1    |   ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
tpv2-e2e-test-1    |    Cypress:        13.6.2                                                                         
tpv2-e2e-test-1    |    Browser:        Electron 114 (headless)                                                        
tpv2-e2e-test-1    |    Node Version:   v20.13.1 (/usr/bin/node)                                                       
tpv2-e2e-test-1    |    Specs:          35 found (login.cy.ts, cacheGroups/detail.cy.ts, cacheGroups/table.cy.ts, deli 
tpv2-e2e-test-1    |                    veryServices/ds.card.cy.ts, deliveryServices/ds.details.cy.ts, deliveryService 
tpv2-e2e-test-1    |                    s/ds.invalidate.cy.ts, cdns/detail.cy.ts, parameters/detail.cy.ts, parameters/ 
tpv2-e2e-test-1    |                    table.cy.ts, statuses/d...)                                                    
tpv2-e2e-test-1    |    Searched:       cypress/e2e/**/*.cy.{js,jsx,ts,tsx}                                            
tpv2-e2e-test-1    |    Experiments:    experimentalInteractiveRunEvents=true                                          
tpv2-e2e-test-1    |   └────────────────────────────────────────────────────────────────────────────────────────────────┘
tpv2-e2e-test-1    |
tpv2-e2e-test-1    |
tpv2-e2e-test-1    | An error was thrown in your plugins file while executing the handler for the before:run event.
tpv2-e2e-test-1    |
tpv2-e2e-test-1    | The error we received was:
tpv2-e2e-test-1    |
tpv2-e2e-test-1    | AggregateError
tpv2-e2e-test-1    |     at Function.AxiosError.from (/lang/traffic-portal/node_modules/axios/lib/core/AxiosError.js:86:14)
tpv2-e2e-test-1    |     at RedirectableRequest.handleRequestError (/lang/traffic-portal/node_modules/axios/lib/adapters/http.js:391:25)
tpv2-e2e-test-1    |     at RedirectableRequest.emit (node:events:519:28)
tpv2-e2e-test-1    |     at RedirectableRequest.emit (node:domain:488:12)
tpv2-e2e-test-1    |     at ClientRequest.eventHandlers.<computed> (/lang/traffic-portal/node_modules/follow-redirects/index.js:38:24)
tpv2-e2e-test-1    |     at ClientRequest.emit (node:events:519:28)
tpv2-e2e-test-1    |     at ClientRequest.emit (node:domain:488:12)
tpv2-e2e-test-1    |     at TLSSocket.socketErrorListener (node:_http_client:500:9)
tpv2-e2e-test-1    |     at TLSSocket.emit (node:events:519:28)
tpv2-e2e-test-1    |     at TLSSocket.emit (node:domain:488:12)
tpv2-e2e-test-1    |     at emitErrorNT (node:internal/streams/destroy:169:8)
tpv2-e2e-test-1    |     at emitErrorCloseNT (node:internal/streams/destroy:128:3)
tpv2-e2e-test-1    |     at processTicksAndRejections (node:internal/process/task_queues:82:21)
tpv2-e2e-test-1    |  Browser application bundle generation complete.

The end-to-end tests pass in GitHub Actions, but Ubuntu is not the recognized supported platform of ATC. The tests need to pass on Rocky Linux 8.

That said, the end-to-end tests fail in CDN-in-a-Box on the master branch, too, so merging #8009 isn't a step backwards as long as CDN in a Box is made to support the TPv2 tests as a follow-up.

@zrhoffman zrhoffman merged commit a892235 into apache:master May 21, 2024
17 checks passed
@zrhoffman
Copy link
Member

TPv2 still runs on Node 16 in CDN in a Box for Developers.

FROM node:16-alpine AS tpv2-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdn-in-a-box related to the Docker-based CDN-in-a-Box system dependencies Pull requests that update a dependency file low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants