Fix Incorrect error message when creating a DS with insufficient Tenancy #7848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntheanh201
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7848 +/- ##
============================================
+ Coverage 29.20% 31.92% +2.71%
Complexity 98 98
============================================
Files 533 719 +186
Lines 71066 82789 +11723
Branches 90 970 +880
============================================
+ Hits 20753 26428 +5675
- Misses 48423 54199 +5776
- Partials 1890 2162 +272
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 186 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
bug
ocket8888
requested changes
Nov 1, 2023
| @@ -388,7 +388,7 @@ func createV50(w http.ResponseWriter, r *http.Request, inf *api.APIInfo, ds tc.D | |||
| return nil, http.StatusInternalServerError, nil, sysErr | |||
| } | |||
| if authorized, err := isTenantAuthorized(inf, &ds); err != nil { | |||
| return nil, http.StatusInternalServerError, nil, fmt.Errorf("checking tenant: %w", err) | |||
| return nil, http.StatusBadRequest, err, fmt.Errorf("checking tenant: %w", err) | |||
There was a problem hiding this comment.
This exposes error information from connections with the database to API clients. One of two things should instead be done:
- check here that the error returned by
isTenantAuthorizeddoes/doesn't represent a failure to find any matching rows and handle appropriately (404 if yes, 500 otherwise) - refactor
isTenantAuthorizedto instead return a third value which indicates whether any such Tenant could be found a ladbhelpers.GetStatusByID(and others). More work, but a better solution IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7321
Change status to 400 Bad request when creating DeliveryService without tenantId
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist